Skip to content

Fix format of nondet volatile command line help #5379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 17, 2020
Merged

Fix format of nondet volatile command line help #5379

merged 4 commits into from
Jun 17, 2020

Conversation

@danpoe
Copy link
Contributor

@danpoe danpoe commented Jun 11, 2020 •
edited
Loading

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

peterschrammel
peterschrammel approved these changes Jun 11, 2020
View reviewed changes
src/goto-instrument/nondet_volatile.h Outdated
" --" NONDET_VOLATILE_MODEL_OPT " <variable>:<model>\n" \
" models reads from given volatile variable " \
"by a call to the given model"
"by a call to the given model\n"
Copy link
Member

@peterschrammel peterschrammel Jun 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏️ would be good if the help text didn't exceed 80 chars.

Copy link
Contributor Author

@danpoe danpoe Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, added a function help_entry() which automatically wraps the text at 80 chars.

@codecov
Copy link

codecov bot commented Jun 11, 2020 •
edited
Loading

Codecov Report

Merging #5379 into develop will increase coverage by 0.01%.
The diff coverage is 97.05%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5379      +/-   ##
===========================================
+ Coverage    68.17%   68.18%   +0.01%     
===========================================
  Files         1173     1173              
  Lines        97461    97494      +33     
===========================================
+ Hits         66445    66478      +33     
  Misses       31016    31016
Flag Coverage Δ
#cproversmt2 42.45% <0.00%> (-0.03%) ⬇️
#regression 65.36% <0.00%> (-0.03%) ⬇️
#unit 32.21% <100.00%> (+0.02%) ⬆️
Impacted Files Coverage Δ
.../goto-instrument/goto_instrument_parse_options.cpp 58.48% <0.00%> (ø)
src/util/parse_options.h 100.00% <ø> (ø)
src/util/string_utils.h 100.00% <ø> (ø)
src/util/parse_options.cpp 77.46% <100.00%> (+8.83%) ⬆️
src/util/string_utils.cpp 92.00% <100.00%> (+1.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91a2257...8307fab. Read the comment docs.

@danpoe danpoe force-pushed the fixes/nondet-volatile-help-message branch 5 times, most recently from 7133e85 to 72fef83 Compare June 17, 2020 08:28
@danpoe danpoe force-pushed the fixes/nondet-volatile-help-message branch from 72fef83 to 8307fab Compare June 17, 2020 10:10
@danpoe danpoe merged commit 7d02492 into diffblue:develop Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterschrammel peterschrammel peterschrammel approved these changes

@chrisr-diffblue chrisr-diffblue Awaiting requested review from chrisr-diffblue

@hannes-steffenhagen-diffblue hannes-steffenhagen-diffblue Awaiting requested review from hannes-steffenhagen-diffblue

@martin-cs martin-cs Awaiting requested review from martin-cs martin-cs is a code owner

@smowton smowton Awaiting requested review from smowton

@kroening kroening Awaiting requested review from kroening kroening is a code owner

@pkesseli pkesseli Awaiting requested review from pkesseli

@tautschnig tautschnig Awaiting requested review from tautschnig tautschnig is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danpoe @peterschrammel